[ 
https://issues.apache.org/jira/browse/HBASE-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771433#comment-13771433
 ] 

Aditya Kishore commented on HBASE-9577:
---------------------------------------

bq.    should probably leave it disabled by default, rather than enabled.
Once the event under troubleshooting has already happened, it might be tool 
late to enable it and restart the service and hope to reproduce.

bq.    why not always log this info at log level DEBUG or TRACE?
Same as previous. Would require restarting the process with the correct log 
level and would defeat the purpose. We would be interested on what was in the 
environment when the event happened (mostly to rule out assumptions).

bq.    how about making the exclusion keywords configurable as well? ie, I may 
want to exclude "passwd", not just "password"
This is something I thought about but seems to be overkill. The only process 
which are going to log these env vars are Master and Region server services and 
I do not see that today we pass anything confidential to either of these 
process. Just trying to keep it simple. Anyone for whom security is of highest 
concern would certainly disable all environment logging.
                
> Log process environment variable on HBase service startup
> ---------------------------------------------------------
>
>                 Key: HBASE-9577
>                 URL: https://issues.apache.org/jira/browse/HBASE-9577
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.95.2, 0.94.11
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>            Priority: Minor
>              Labels: troubleshooting
>             Fix For: 0.96.0
>
>         Attachments: HBASE-9577.patch, HBASE-9577.patch
>
>
> HBase services already logs information related to JVM properties and command 
> line arguments used to start the services which have been immensely helpful 
> to investigate issues.
> One thing that they do not log is the environment variables and an unintended 
> variable in the environment could lead to a scenario not reproducible 
> anywhere else including its original location if the service is restarted 
> differently.
> We should log environment variables (excluding those which may contains 
> credentials) on service startup with option to disable this logging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to