[
https://issues.apache.org/jira/browse/HBASE-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045199#comment-13045199
]
[email protected] commented on HBASE-2233:
------------------------------------------------------
bq. On 2011-06-06 22:51:07, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java, line 360
bq. > <https://reviews.apache.org/r/858/diff/1/?file=20611#file20611line360>
bq. >
bq. > is this change related?
Not related but needed. I could do in separate issue. Saw ugly NPE when
stuff came up ugly when not patched properly.
bq. On 2011-06-06 22:51:07, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java, line
791
bq. > <https://reviews.apache.org/r/858/diff/1/?file=20613#file20613line791>
bq. >
bq. > hrm, I dont understand this line
Good one. Test should be inverted. Fixing...
bq. On 2011-06-06 22:51:07, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java, line
1343
bq. > <https://reviews.apache.org/r/858/diff/1/?file=20613#file20613line1343>
bq. >
bq. > did our behavior here change? I think we used to return null, but I
thought now we returned an empty list?
fs.listStatus changed in that if you pass it a dir that does not exist, before
it would return empty list but no throws FileNotFoundException.
Regards our behavior changing around the return out of this method, I don't
think so. I looked at 0.90 and it does this too:
if (files == null) return filesSorted;
... returning empty NavigableSet if nothing found.
bq. On 2011-06-06 22:51:07, Todd Lipcon wrote:
bq. > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java,
line 127
bq. > <https://reviews.apache.org/r/858/diff/1/?file=20621#file20621line127>
bq. >
bq. > CONFI?
Yeah. Takes variable named 'conf1'. I changed it to be less surprising
CONF_WITH_LOCALFS
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/858/#review769
-----------------------------------------------------------
On 2011-06-06 22:27:56, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/858/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-06 22:27:56)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch for HBASE TRUNK that makes it so we run on hadoop 0.20.x or hadoop
0.22 branch (as it is now).
bq.
bq. Needed hdfs-1948 and hadoop-7531 applied to hadoop 0.22 branch. Because
these issues are NOT in hadoop 0.21, hbase will not work against 0.21 hadoop,
not w/o these patches and a rebuild.
bq.
bq.
bq. This addresses bug HBASE-2233.
bq. https://issues.apache.org/jira/browse/HBASE-2233
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/ipc/ConnectionHeader.java c2a7649
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
95407d1
bq.
src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport/InputSampler.java
c3e0a68
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java b8489ac
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java f735e41
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
6404538
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 0716788
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
db29e56
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
8dc9a5e
bq. src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 3409108
bq. src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 6ed9fe6
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java babd788
bq.
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
f6a7210
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
f1f4c6b
bq. src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
5b487a9
bq. src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java c8fc065
bq.
bq. Diff: https://reviews.apache.org/r/858/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran this patch with hadoop 0.20 and hadoop 0.22 underneath hbase (I used
the patch for the pom that is attached to the issue to switch to hadoop 0.22).
All unit tests seem to pass except TestHFileOutputFormat when up on hadoop
0.22; hadoop 0.22 uses avro 1.3.2 whereas hbase is up on avro 1.4.1. The test
fails with a method not found exception. You need to enable mapreduce logging
to see the exception.
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Support both Hadoop 0.20, 0.21, and 0.22
> ----------------------------------------
>
> Key: HBASE-2233
> URL: https://issues.apache.org/jira/browse/HBASE-2233
> Project: HBase
> Issue Type: New Feature
> Reporter: Jean-Daniel Cryans
> Assignee: stack
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 2233-v2.txt, 2233-v3.txt, 2233-v4.txt, 2233-v5.txt,
> 2233.txt, pom.to.go.against.hadoop.trunk.txt
>
>
> Since Hadoop 0.21 isn't going to be well supported and that a lot of users
> may wish to stick on 0.20, the next HBase major release should support both
> 0.20 and 0.21.
> HDFS-265 support will be swapped for HDFS-200 if running on HDFS 0.20. A
> cluster without that patchset shouldn't be supported.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
