[ 
https://issues.apache.org/jira/browse/HBASE-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774705#comment-13774705
 ] 

Jean-Marc Spaggiari commented on HBASE-9606:
--------------------------------------------

One quick question here.

{code}
+      int scannerCaching = 
configuration.getInt(HConstants.HBASE_META_SCANNER_CACHING,
+        HConstants.DEFAULT_HBASE_META_SCANNER_CACHING);
+      if (rowUpperLimit <= scannerCaching) {
+          scan.setSmall(true);
+      }
+      int rows = Math.min(rowLimit, scannerCaching)
{code}

Should we not set the setSmall flag on the rows value and not just only the 
rowUpperLimit?

Like:
+      int scannerCaching = 
configuration.getInt(HConstants.HBASE_META_SCANNER_CACHING,
+        HConstants.DEFAULT_HBASE_META_SCANNER_CACHING);
+      int rows = Math.min(rowLimit, scannerCaching);
+      if (rowUpperLimit <= rows) {
+          scan.setSmall(true);
+      }
{code}
Or something similar?
                
> Apply small scan to meta scan where rowLimit is low
> ---------------------------------------------------
>
>                 Key: HBASE-9606
>                 URL: https://issues.apache.org/jira/browse/HBASE-9606
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 9606-v2.txt, small-v3.txt
>
>
> HBASE-9488 added the feature for small scan where RPC calls are reduced.
> We can apply small scan to MetaScanner#metaScan() where rowLimit is low.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to