[ 
https://issues.apache.org/jira/browse/HBASE-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776545#comment-13776545
 ] 

Robert Roland commented on HBASE-9588:
--------------------------------------

Okay, tests are in along with other feedback. v2 of the patch was missing a 
test - I forgot an svn add before my svn diff.

The only additional thing I had in mind with this patch were comparators for 
convenience: LongComparator, FloatComparator, BooleanComparator, 
DoubleComparator, IntComparator, ShortComparator, BigDecimalComparator. 
Basically, Comparators for all the types that the Bytes utility class has. I 
was considering submitting those as a separate patch / issue if this patch is 
accepted.
                
> Expose checkAndPut/checkAndDelete with comparators to HTableInterface
> ---------------------------------------------------------------------
>
>                 Key: HBASE-9588
>                 URL: https://issues.apache.org/jira/browse/HBASE-9588
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0
>            Reporter: Robert Roland
>         Attachments: checkAndPut_HBASE-9588_0.94.patch, 
> checkAndPut_HBASE-9588_TRUNK.patch, checkAndPut_HBASE-9588_TRUNK.patch.1, 
> checkAndPut_HBASE-9588_TRUNK-v2.patch, checkAndPut_HBASE-9588_TRUNK-v3.patch
>
>
> HRegionInterface allows you to specify a comparator to checkAndPut and 
> checkAndDelete, but that isn't available to the standard HTableInterface.
> The attached patches expose these functions to the client. It adds two 
> methods to HTableInterface, which required implementing in several places.
> They are not implemented in RemoteHTable - I couldn't see an obvious way to 
> implement there. Following the pattern of increment, batch, etc, they are 
> "not supported."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to