[
https://issues.apache.org/jira/browse/HBASE-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779378#comment-13779378
]
Jonathan Hsieh commented on HBASE-9548:
---------------------------------------
Seems funny to not close this -- does util have an implicit close?
{code}
@After
public void tearDown() throws Exception {
- admin.close();
+ SnapshotTestingUtils.deleteAllSnapshots(admin);
}
{code}
nit: Add comment about what false is so reader doesn't have to hunt it down?
{code}
SnapshotTestingUtils.createSnapshotAndValidate(admin, originalTableName,
- familiesWithDataList, emptyFamiliesList, snapshotNameAsString, rootDir,
fs);
+ familiesWithDataList, emptyFamiliesList, snapshotNameAsString, rootDir,
fs, false);
{code}
> Cleanup SnapshotTestingUtils
> ----------------------------
>
> Key: HBASE-9548
> URL: https://issues.apache.org/jira/browse/HBASE-9548
> Project: HBase
> Issue Type: Bug
> Components: snapshots, test
> Affects Versions: 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Trivial
> Fix For: 0.96.1
>
> Attachments: HBASE-9548-v0.patch
>
>
> Remove some duplicated code in SnapshotTestingUtils, use existing helpers and
> fix some stuff
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
