[ 
https://issues.apache.org/jira/browse/HBASE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781563#comment-13781563
 ] 

stack commented on HBASE-9576:
------------------------------

The patch that was on this issue went in as a sub-task.

This is item #1.  #2 and #3 are another subtask looking for a +1.

> Fixups in hbase protobuf
> ------------------------
>
>                 Key: HBASE-9576
>                 URL: https://issues.apache.org/jira/browse/HBASE-9576
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>            Reporter: stack
>         Attachments: 0001-HBASE-9576-task1.patch
>
>
> Benoit was looking at out pbs.  Had following remarks:
> {code}
> ...there is something that doesn't make sense to me...a MutateRequest can 
> have a Condition...the Condition has row/family/qualifier...so for a single 
> KV CAS, one needs to specify the...row/family/qualifier twice...once in the 
> MutationProto and once in the Condition...not a huge deal...just weird
> ...also in Comparator.proto, both BinaryComparator and BinaryPrefixComparator 
> (and BitComparator too actually) would have been better off without 
> ByteArrayComparable, which seems a useless pb, but no big deal either
> {code}
> Will keep this issue open as place to accumulate pb fixups.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to