[
https://issues.apache.org/jira/browse/HBASE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782281#comment-13782281
]
stack commented on HBASE-9612:
------------------------------
All these tests failed post commit though above it seemed to pass. Reverted
till figure it out:
org.apache.hadoop.hbase.TestFullLogReconstruction.testReconstruction
org.apache.hadoop.hbase.client.TestAdmin.testForceSplitMultiFamily
org.apache.hadoop.hbase.client.TestFromClientSide.testPutNoCF
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor.testPutNoCF
org.apache.hadoop.hbase.client.TestHTableMultiplexer.testHTableMultiplexer
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithIncrementAndAppend
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithGet
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithPut
org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsWithAbort
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithManyColsInOneRowGetAndPut
org.apache.hadoop.hbase.client.TestMultiParallel.testHTableDeleteWithList
org.apache.hadoop.hbase.client.TestMultiParallel.testBadFam
org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsNoAbort
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithDelete
org.apache.hadoop.hbase.client.TestMultiParallel.testBatchWithMixedActions
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testRestoreSchemaChange
org.apache.hadoop.hbase.constraint.TestConstraint.testIsUnloaded
org.apache.hadoop.hbase.constraint.TestConstraint.testConstraintFails
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove.testExceptionFromCoprocessorDuringPut
org.apache.hadoop.hbase.mapred.TestTableMapReduce.testMultiRegionTable
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.testMultithreadedTableMapper
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1.testScanEmptyToOPP
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2.testScanYYXToEmpty
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2.testScanOBBToOPP
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2.testScanOBBToQPP
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2.testScanFromConfiguration
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testCombiner
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testMultiRegionTable
org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testDisallowWritesInRecovering
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS.killOneMasterRS
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.killOneMasterRS
org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS.killOneSlaveRS
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testFlushCreateListDestroy
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSnapshotStateAfterMerge
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testTakeSnapshotAfterMerge
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testFlushTableSnapshot
org.apache.hadoop.hbase.util.TestHBaseFsck.testHBaseFsckClean
org.apache.hadoop.hbase.util.TestHBaseFsck.testCoveredStartKey
org.apache.hadoop.hbase.util.TestHBaseFsck.testFixHdfsHolesNotWorkingWithNoHdfsChecking
org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineMissingHFile
org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineCorruptHFile
org.apache.hadoop.hbase.util.TestHBaseFsck.testLingeringSplitParent
org.apache.hadoop.hbase.util.TestHBaseFsck.testValidLingeringSplitParent
org.apache.hadoop.hbase.util.TestHBaseFsck.testFixMetaNotWorkingWithNoHdfsChecking
org.apache.hadoop.hbase.util.TestHBaseFsck.testHDFSRegioninfoMissing
org.apache.hadoop.hbase.util.TestHBaseFsck.testNoHdfsTable
org.apache.hadoop.hbase.util.TestHBaseFsck.testDupeRegion
org.apache.hadoop.hbase.util.TestHBaseFsck.testContainedRegionOverlap
org.apache.hadoop.hbase.util.TestHBaseFsck.testDupeStartKey
org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInMetaHole
org.apache.hadoop.hbase.util.TestHBaseFsck.testMissingLastRegion
org.apache.hadoop.hbase.util.TestHBaseFsck.testFixByTable
org.apache.hadoop.hbase.util.TestHBaseFsck.testSidelineOverlapRegion
org.apache.hadoop.hbase.util.TestHBaseFsck.testFixAssignmentsAndNoHdfsChecking
org.apache.hadoop.hbase.util.TestHBaseFsck.testLingeringReferenceFile
org.apache.hadoop.hbase.util.TestHBaseFsck.testSplitDaughtersNotInMeta
org.apache.hadoop.hbase.util.TestHBaseFsck.testOverlapAndOrphan
org.apache.hadoop.hbase.util.TestHBaseFsck.testRegionHole
org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInHdfs
org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInMetaOrDeployedHole
org.apache.hadoop.hbase.util.TestHBaseFsck.testDegenerateRegions
org.apache.hadoop.hbase.util.TestHBaseFsck.testMissingFirstRegion
org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineMissingRegionDir
> Ability to batch edits destined to different regions
> ----------------------------------------------------
>
> Key: HBASE-9612
> URL: https://issues.apache.org/jira/browse/HBASE-9612
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.0, 0.95.1, 0.95.2, 0.96.0
> Reporter: Benoit Sigoure
> Assignee: stack
> Priority: Critical
> Fix For: 0.98.0, 0.96.0
>
> Attachments: 9612.096.v5.txt, 9612revert.txt, 9612v2.txt, 9612v3.txt,
> 9612v4.txt, 9612v5.txt, 9612v5.txt, 9612.wip.txt
>
>
> The old (pre-PB) "multi" and "multiPut" RPCs allowed one to batch edits
> destined to different regions. Seems like we've lost this ability after the
> switch to protobufs.
> The {{MultiRequest}} only contains one {{RegionSpecifier}}, and a list of
> {{MultiAction}}. The {{MultiAction}} message is contains either a single
> {{MutationProto}} or a {{Get}} (but not both – so its name is misleading as
> there is nothing "multi" about it). Also it seems redundant with
> {{MultiGetRequest}}, I'm not sure what's the point of supporting {{Get}} in
> {{MultiAction}}.
> I propose that we change {{MultiRequest}} to be a just a list of
> {{MultiAction}}, and {{MultiAction}} will contain the {{RegionSpecifier}},
> the {{bool atomic}} and a list of {{MutationProto}}. This would be a
> non-backward compatible protobuf change.
> If we want we can support mixing edits and reads, in which case we'd also add
> a list of {{Get}} in {{MultiAction}}, and we'd have support having both that
> list and the list of {{MutationProto}} set at the same time. But this is a
> bonus and can be done later (in a backward compatible manner, hence no need
> to rush on this one).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
