[ 
https://issues.apache.org/jira/browse/HBASE-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782556#comment-13782556
 ] 

Hadoop QA commented on HBASE-9688:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12606015/9688.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestAsyncProcess

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7424//console

This message is automatically generated.

> Fix javadoc warning in HConnectionManager class javadoc
> -------------------------------------------------------
>
>                 Key: HBASE-9688
>                 URL: https://issues.apache.org/jira/browse/HBASE-9688
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 9688.patch
>
>
> From 
> https://builds.apache.org/job/PreCommit-HBASE-Build/7422/artifact/trunk/patchprocess/patchJavadocWarnings.txt
>  :
> {code}
> [WARNING] Javadoc Warnings
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:193:
>  warning - End Delimiter } missing for possible See Tag in comment string: "A 
> non-instantiable class that manages creation of {@link HConnection}s.
> [WARNING] <p>The simplest way to use this class is by using {@link 
> #createConnection(Configuration)}.
> [WARNING] This creates a new {@link HConnection} to the cluster that is 
> managed by the caller.
> [WARNING] From this {@link HConnection} {@link HTableInterface} 
> implementations are retrieved
> [WARNING] with {@link HConnection#getTable(byte[])}. Example:
> [WARNING] <pre>
> [WARNING] {@code
> [WARNING] HConnection connection = 
> HConnectionManager.createConnection(config);
> [WARNING] HTableInterface table = connection.getTable("table1");
> [WARNING] try {
> [WARNING] // Use the table as needed, for a single operation and a single 
> thread
> [WARNING] } finally {
> [WARNING] table.close();
> [WARNING] connection.close();
> [WARNING] }
> [WARNING] </pre>
> [WARNING] <p>The following logic and API will be removed in the future:
> [WARNING] <p>This class has a static Map of {@link HConnection} instances 
> keyed by
> {code}
> The @code misses right brace



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to