[
https://issues.apache.org/jira/browse/HBASE-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782561#comment-13782561
]
Enis Soztutar commented on HBASE-9514:
--------------------------------------
v5.3 has a simple compilation error. Do you mind putting this version to RB as
well.
{code}
+ if (!runVerify(outputDir, numReducers, expectedNumNodes, true)) {
+ LOG.info("Verify.verify failed, let's stop CM and verify again");
+ it.cleanUpMonkey("Monkey broke something");
+ if (!runVerify(outputDir, numReducers, expectedNumNodes, false)) {
+ throw new RuntimeException("Verify.verify failed");
+ }
{code}
I did not get why we are running verify again. No matter what, if verify failed
once, we should fail the test.
Other changes look ok to me. although, it is still hard to follow what the edge
cases might be. The tests are still running.
> Prevent region from assigning before log splitting is done
> ----------------------------------------------------------
>
> Key: HBASE-9514
> URL: https://issues.apache.org/jira/browse/HBASE-9514
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: trunk-9514_v1.patch, trunk-9514_v2.patch,
> trunk-9514_v3.patch, trunk-9514_v5.1.patch, trunk-9514_v5.1.patch,
> trunk-9514_v5.2.patch, trunk-9514_v5.3.patch, trunk-9514_v5.patch
>
>
> If a region is assigned before log splitting is done by the server shutdown
> handler, the edits belonging to this region in the hlogs of the dead server
> will be lost.
> Generally this is not an issue if users don't assign/unassign a region from
> hbase shell or via hbase admin. These commands are marked for experts only in
> the hbase shell help too. However, chaos monkey doesn't care.
> If we can prevent from assigning such regions in a bad time, it would make
> things a little safer.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
