[ 
https://issues.apache.org/jira/browse/HBASE-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783550#comment-13783550
 ] 

Hadoop QA commented on HBASE-9697:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12606212/HBASE-9697-v0-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs 
(version 1.3.9) to fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestAsyncProcess

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7439//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7439//console

This message is automatically generated.

> ZKDataMigrator should exit on table(s) null check.
> --------------------------------------------------
>
>                 Key: HBASE-9697
>                 URL: https://issues.apache.org/jira/browse/HBASE-9697
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0, 0.96.1
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-9697-v0-trunk.patch
>
>
> Doing something like that in 2 places:
> {code}
>     if (tables == null) {
>       LOG.info("No table present to migrate table state to PB. returning..");
>     }
>     for (String table : tables) {
> {code}
> We need to return just after logging.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to