[
https://issues.apache.org/jira/browse/HBASE-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784820#comment-13784820
]
Ted Yu commented on HBASE-9546:
-------------------------------
{code}
+ public HFileContext(boolean useHBaseChecksum, boolean includesMvcc, boolean
includesTags, Algorithm compressAlgo, boolean compressTags,
+ ChecksumType checksumType, int bytesPerChecksum, int blockSize,
DataBlockEncoding encodingOnDisk, DataBlockEncoding encodingInCache) {
{code}
Long line above.
{code}
+public class HFileContextBuilder {
{code}
Please add annotation for audience.
Patch looks good.
> HFileContext should adopt Builder pattern
> -----------------------------------------
>
> Key: HBASE-9546
> URL: https://issues.apache.org/jira/browse/HBASE-9546
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-9546.patch
>
>
> HFileContext is used in so many places for HFile v3, HFileContext should use
> the Builder pattern.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
