[
https://issues.apache.org/jira/browse/HBASE-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791216#comment-13791216
]
Jeffrey Zhong commented on HBASE-9696:
--------------------------------------
{quote}
If hri is null, it returns false
{quote}
Thanks for pointing this out. I saw inside your patch (the following several
lines) should address the JIRA issue. The rest is more like enhancement. Is
that possible to split the patch into two: one as bug fix(to mitigate impacts)
and the rest as enhancement?
{code}
+ EventType et = rt.getEventType();
+ if (hri == null && et != EventType.RS_ZK_REGION_MERGING
- final String encodedRegionName = regionInfo.getEncodedName();
- final String prettyPrintedRegionName =
HRegionInfo.prettyPrint(encodedRegionName);
- LOG.info("Processing " + regionInfo.getRegionNameAsString() + " in state "
+ et);
-
+ final byte[] regionName = rt.getRegionName();
+ final String encodedName = HRegionInfo.encodeRegionName(regionName);
+ final String prettyPrintedRegionName =
HRegionInfo.prettyPrint(encodedName);
+ LOG.info("Processing " + prettyPrintedRegionName + " in state " + et);
- if (regionStates.isRegionInTransition(encodedRegionName)) {
+ if (regionStates.isRegionInTransition(encodedName)) {
{code}
> Master recovery ignores online merge znode
> ------------------------------------------
>
> Key: HBASE-9696
> URL: https://issues.apache.org/jira/browse/HBASE-9696
> Project: HBase
> Issue Type: Bug
> Components: master, Region Assignment
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.98.0, 0.96.1
>
> Attachments: trunk-9696.patch, trunk-9696_v2.patch
>
>
> The online merge znode uses the new region to be created. When master
> restarts, the new region is still unknown if the merging is not completed.
> Therefore the znode is ignored, which should not. That means the two merging
> regions could be moved around. This could cause some data loss if we are not
> luck.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
