[
https://issues.apache.org/jira/browse/HBASE-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793515#comment-13793515
]
Lars Hofhansl commented on HBASE-9751:
--------------------------------------
[~vrodionov], I think you're correct. The readpoint is set by the
RegionScannerImpl and it should use the same readpoint upon each invocation.
Thus getting the readpoint from the threadlocal is mere code convenience rather
than needed for correctness.
Feel like adding a patch to HBASE-9753?
I'll commit this one.
> Excessive readpoints checks in StoreFileScanner
> ------------------------------------------------
>
> Key: HBASE-9751
> URL: https://issues.apache.org/jira/browse/HBASE-9751
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0, 0.94.12, 0.96.0
> Reporter: Vladimir Rodionov
> Assignee: Lars Hofhansl
> Fix For: 0.98.0, 0.94.13, 0.96.1
>
> Attachments: 9751-0.94.txt, 9751-trunk.txt
>
>
> It seems that usage of skipKVsNewerThanReadpoint in StoreFileScanner can be
> greatly reduced or even eliminated all together (HFiles are immutable and no
> new KVs can be inserted after scanner instance is created). The same is true
> for MemStoreScanner which checks readpoint on every next() and seek(). Each
> readpoint check is ThreadLocal.get() and it is quite expensive.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
