[ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050546#comment-13050546
 ] 

stack commented on HBASE-3996:
------------------------------

@Eran Looks great.

Some comments.

Notice how other hbase classes use two spaces for tab and line lengths are 80 
chars or less (generally).

Check your javadoc.  Some suffers copy and paste-isms (I think).

Can you add the above usage into class comment or if that doesn't make sense, 
into the package javadoc.  It would be a tradegy if this sweet new 
functionality went unused just because it could not be found.

Any chance of a basic unit test.  I know spinning up a MR cluster and an HBase 
cluster and an HDFS all in the one JVM is profane, but it does help features 
persevere through changes that don't seem related but because the unit test 
fails, the connection shows at unit test time rather than at deploy.

(You know how to make a patch?  If you svn add the new classes or git add and 
git commit, then you can make a patch file with new classes).

Thanks Eran.



> Support multiple tables and scanners as input to the mapper in map/reduce jobs
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-3996
>                 URL: https://issues.apache.org/jira/browse/HBASE-3996
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Eran Kutner
>             Fix For: 0.90.4
>
>         Attachments: MultiTableInputCollection.java, 
> MultiTableInputFormat.java, MultiTableInputFormatBase.java, 
> TableMapReduceUtil.java, TableSplit.java
>
>
> It seems that in many cases feeding data from multiple tables or multiple 
> scanners on a single table can save a lot of time when running map/reduce 
> jobs.
> I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to