[ 
https://issues.apache.org/jira/browse/HBASE-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800810#comment-13800810
 ] 

Ted Yu commented on HBASE-9543:
-------------------------------

Took a quick look at the patch.
This feature is about getting unique values in selected range of rows. Should 
the method name be more specific so that the functionality is clearer ?
{code}
+          if (colSet.size() > uniqueNumLimit) {
+            throw new IOException("uniqe column value num is larger than 
limit: "
+                + uniqueNumLimit + ", check scan params, or set the conf: "
+                + HConstants.HBASE_AGGREGATION_UNIQUE_MAXSIZE);
{code}
Once the client receives IOException, adjustment has to be made for the next 
call. Can we return partial results ?

It would be nice to post the patch on reviews.apache.org

>  Impl unique aggregation
> ------------------------
>
>                 Key: HBASE-9543
>                 URL: https://issues.apache.org/jira/browse/HBASE-9543
>             Project: HBase
>          Issue Type: New Feature
>          Components: Coprocessors
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-9543-0.94-v1.diff, HBASE-9543-trunk-v1.diff, 
> HBASE-9543-trunk-v2.diff, HBASE-9543-trunk-v3.diff, HBASE-9543-trunk-v4.diff
>
>
> Impl unique aggregation: return a set of all columns' values in a scan.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to