[ 
https://issues.apache.org/jira/browse/HBASE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803283#comment-13803283
 ] 

stack commented on HBASE-9221:
------------------------------

Patch looks good.

Any danger of this being the default; i.e. a new Connection each time?

+   * @param ticket Be careful which ticket you pass. A new user will mean a 
new Connection.
+   *          {@link UserProvider#getCurrent()} makes a new instance of User 
each time so will be a
+   *          new Connection each time.

Is that just a module move for the User class?

Is the remove of hbase-protocol/src/main/protobuf/HBase.proto intended?

Else patch lgtm.

> Provide interface for getting a User in the client
> --------------------------------------------------
>
>                 Key: HBASE-9221
>                 URL: https://issues.apache.org/jira/browse/HBASE-9221
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, hadoop2, security
>    Affects Versions: 0.98.0, 0.95.2, 0.94.12
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.98.0, 0.94.13, 0.96.1
>
>         Attachments: hbase-9221-0.94-v0.patch, hbase-9221-0.94-v1.patch, 
> hbase-9221-trunk-v0.patch, hbase-9221-trunk-v1.patch, 
> hbase-9221-trunk-v2.patch, hbase-9221-trunk-v3.patch
>
>
> Sometimes, users will want to provide their own User class depending on the 
> type of security they will support in their local environment. For instance, 
> running Hadoop1 vs Hadoop2 vs CDH means potentially different ways of getting 
> the UserGroupInformation. 
> This issue abstracts out the mechanism by which we obtain an 
> o.a.h.hbase.security.User to a UserProvider. This UserProvider can then be 
> extented as a Hadoop 1/2 shim as well as supporting custom authentication 
> code.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to