[
https://issues.apache.org/jira/browse/HBASE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805864#comment-13805864
]
Enis Soztutar commented on HBASE-8543:
--------------------------------------
A couple of comments:
- @Category(SmallTests.class) seems ok since we are not booting a cluster.
- Can you copy paste the license headers for the new files from some other
java file. We are using the version which is limited to 80 chars per line
mostly.
- TestRemoteHTableRetries.MAX_TIME should also be MAX_TIME = SLEEP_TIME *
(RETRIES - 1) ?
- We should not need this:
{code}
- assertEquals(1, results[0].size());
- assertEquals(3, results[1].size());
+ assertEquals(2, results[0].size());
+ assertEquals(4, results[1].size());
{code}
It seems that the individual test methods are not independent. Can you please
make it so that each method uses it's own table, so that the test results won't
depend on run order.
Otherwise looks good.
> fix coverage org.apache.hadoop.hbase.rest.client
> ------------------------------------------------
>
> Key: HBASE-8543
> URL: https://issues.apache.org/jira/browse/HBASE-8543
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.8, 0.95.2
> Reporter: Aleksey Gorshkov
> Assignee: Andrey Klochkov
> Attachments: HBASE-8543-0.94--N2.patch, HBASE-8543-0.94.patch,
> HBASE-8543-trunk--N2.patch, HBASE-8543-trunk--n3.patch,
> HBASE-8543-trunk--n4.patch, HBASE-8543-trunk--n5.patch, HBASE-8543-trunk.patch
>
>
> fix coverage org.apache.hadoop.hbase.rest.client
--
This message was sent by Atlassian JIRA
(v6.1#6144)
