[
https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810991#comment-13810991
]
Hudson commented on HBASE-9867:
-------------------------------
FAILURE: Integrated in HBase-TRUNK #4662 (See
[https://builds.apache.org/job/HBase-TRUNK/4662/])
HBASE-9867 Save on array copies with a subclass of LiteralByteString (stack:
rev 1537750)
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/RegionTransition.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
* /hbase/trunk/hbase-protocol/src/main/java/com
* /hbase/trunk/hbase-protocol/src/main/java/com/google
* /hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf
*
/hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/codec/MessageCodec.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/Reference.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableInfoModel.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
> Save on array copies with a subclass of LiteralByteString
> ---------------------------------------------------------
>
> Key: HBASE-9867
> URL: https://issues.apache.org/jira/browse/HBASE-9867
> Project: HBase
> Issue Type: Improvement
> Components: Protobufs
> Affects Versions: 0.96.0
> Reporter: stack
> Assignee: stack
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9867.096.txt, 9867.txt, 9867.txt, 9867v2.txt
>
>
> Any time we add a byte array to a protobuf, it'll copy the byte array.
> I was playing with the client and noticed how a bunch of CPU and copying was
> being done just to copy basic arrays doing pb construction. I started to
> look at ByteString and then remembered a class Benoit sent me a while back
> that I did not understand from his new AsyncHBase. After looking in
> ByteString it made now sense. So, rather than copy byte arrays everywhere,
> do a version of a ByteString that instead wraps the array.
--
This message was sent by Atlassian JIRA
(v6.1#6144)