[
https://issues.apache.org/jira/browse/HBASE-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812274#comment-13812274
]
stack commented on HBASE-9816:
------------------------------
Fix this on commit:
+ * Tags are part of Keyvalues and helps to add metadata about the KVs.
Should be Cells
You did not intend to have this in your patch I'm sure
+<<<<<<< HEAD
+ if (encodingCtx.getHFileContext().isIncludesTags()) {
+ int tagsLength = in.getShort();
+=======
if (encodingCtx.getHFileContext().shouldIncludeTags()) {
short tagsLength = in.getShort();
+>>>>>>> upstream/trunk
There are a few instances
Is this right?
- // TODO : This setter should be removed
public void setIncludesMvcc(boolean includesMvcc) {
this.includesMvcc = includesMvcc;
}
You remove the comment and not the setter?
Else the patch is looking good.
> Address review comments in HBASE-8496
> -------------------------------------
>
> Key: HBASE-9816
> URL: https://issues.apache.org/jira/browse/HBASE-9816
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.98.0
>
> Attachments: HBASE-9816.patch, HBASE-9816_1.patch, HBASE-9816_1.patch
>
>
> This JIRA would be used to address the review comments in HBASE-8496. Any
> more comments would be addressed and committed as part of this. There are
> already few comments from Stack on the RB.
> https://reviews.apache.org/r/13311/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
