[ 
https://issues.apache.org/jira/browse/HBASE-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812824#comment-13812824
 ] 

Hadoop QA commented on HBASE-9885:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12611952/9885.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7723//console

This message is automatically generated.

> Avoid some Result creation in protobuf conversions
> --------------------------------------------------
>
>                 Key: HBASE-9885
>                 URL: https://issues.apache.org/jira/browse/HBASE-9885
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Protobufs, regionserver
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9885.v1.patch
>
>
> We creates a lot of Result that we could avoid, as they contain nothing else 
> than a boolean value. We create sometimes a protobuf builder as well on this 
> path, this can be avoided.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to