[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867

[Nicolas Liochon (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812867#comment-13812867
 ] 

Nicolas Liochon commented on HBASE-9880:
----------------------------------------

trunk has this already. Not clear why 0.96 does not. There is no difference 
between the two branches for AsyncProcess. 
{noformat}
$ git diff 0.96 clean -- 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
index 21447e0..00de79e 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
@@ -207,7 +207,7 @@ public class HTable implements HTableInterface {
     this.pool = getDefaultExecutor(this.configuration);
     this.finishSetup();
   }
-
+   
   public static ThreadPoolExecutor getDefaultExecutor(Configuration conf) {
     int maxThreads = conf.getInt("hbase.htable.threads.max", 
Integer.MAX_VALUE);
     if (maxThreads == 0) {
@@ -911,7 +911,6 @@ public class HTable implements HTableInterface {
    */
   private void backgroundFlushCommits(boolean synchronous) throws
       InterruptedIOException, RetriesExhaustedWithDetailsException {
-    if (this.writeAsyncBuffer.isEmpty()) return;
 
     try {
       do {
@@ -1230,7 +1229,7 @@ public class HTable implements HTableInterface {
       return;
     }
     flushCommits();
-    if (cleanupPoolOnClose && this.pool != null) {
+    if (cleanupPoolOnClose) {
       this.pool.shutdown();
     }
     if (cleanupConnectionOnClose) {
{noformat}

> client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 
> --------------------------------------------------------------------------
>
>                 Key: HBASE-9880
>                 URL: https://issues.apache.org/jira/browse/HBASE-9880
>             Project: HBase
>          Issue Type: Test
>            Reporter: stack
>            Assignee: stack
>         Attachments: 9880.v1.patch
>
>
> It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk).  
> This was my patch.  Let me fix.



--
This message was sent by Atlassian JIRA
(v6.1#6144)