[
https://issues.apache.org/jira/browse/HBASE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815787#comment-13815787
]
Hadoop QA commented on HBASE-9902:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12612543/HBASE-9902.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestClockSkewDetection
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7776//console
This message is automatically generated.
> Region Server is starting normally even if clock skew is more than default 30
> seconds(or any configured). -> Regionserver node time is greater than master
> node time
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-9902
> URL: https://issues.apache.org/jira/browse/HBASE-9902
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.11
> Reporter: Kashif J S
> Fix For: 0.98.0, 0.96.1
>
> Attachments: HBASE-9902.patch
>
>
> When Region server's time is ahead of Master's time and the difference is
> more than hbase.master.maxclockskew value, region server startup is not
> failing with ClockOutOfSyncException.
> This causes some abnormal behavior as detected by our Tests.
> ServerManager.java#checkClockSkew
> long skew = System.currentTimeMillis() - serverCurrentTime;
> if (skew > maxSkew) {
> String message = "Server " + serverName + " has been " +
> "rejected; Reported time is too far out of sync with master. " +
> "Time difference of " + skew + "ms > max allowed of " + maxSkew +
> "ms";
> LOG.warn(message);
> throw new ClockOutOfSyncException(message);
> }
> Above line results in negative value when Master's time is lesser than
> region server time and " if (skew > maxSkew) " check fails to find the skew
> in this case.
> Please Note: This was tested in hbase 0.94.11 version and the trunk also
> currently has the same logic.
> The fix for the same would be to make the skew positive value first as below:
> long skew = System.currentTimeMillis() - serverCurrentTime;
> skew = (skew < 0 ? -skew : skew);
> if (skew > maxSkew) {.....
--
This message was sent by Atlassian JIRA
(v6.1#6144)
