[
https://issues.apache.org/jira/browse/HBASE-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816330#comment-13816330
]
Enis Soztutar commented on HBASE-9908:
--------------------------------------
Thanks Nick for taking a look.
bq. Adding get and setConfiguration, any value in extending Configurable?
Agreed that we can do it. These method sigs are just moved one level up to
HBaseCommonTestingUtil. If we extend Configured, the method sigs will change as
well, which will make he patch much bigger.
bq. All green lights in the Windows host?
For the fixed test cases, yes.
bq. Do we have Windows jenkins slaves yet?
Not yet. See HBASE-6819. There is some server donations happening, but not
fully finished.
bq. Looks good to me. +1.
Will commit this by EOD to trunk and 0.96 unless objection.
> [WINDOWS] Fix filesystem / classloader related unit tests
> ---------------------------------------------------------
>
> Key: HBASE-9908
> URL: https://issues.apache.org/jira/browse/HBASE-9908
> Project: HBase
> Issue Type: Bug
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.98.0, 0.96.1
>
> Attachments: hbase-9908_v1.patch
>
>
> Some of the unit tests related to classloasing and filesystem are failing on
> windows.
> {code}
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testHBase3810
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testClassLoadingFromLocalFS
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testPrivateClassLoader
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testClassLoadingFromRelativeLibDirInJar
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testClassLoadingFromLibDirInJar
> org.apache.hadoop.hbase.coprocessor.TestClassLoading.testClassLoadingFromHDFS
> org.apache.hadoop.hbase.backup.TestHFileArchiving.testCleaningRace
> org.apache.hadoop.hbase.regionserver.wal.TestDurability.testDurability
> org.apache.hadoop.hbase.regionserver.wal.TestHLog.testMaintainOrderWithConcurrentWrites
> org.apache.hadoop.hbase.security.access.TestAccessController.testBulkLoad
> org.apache.hadoop.hbase.regionserver.TestHRegion.testRecoveredEditsReplayCompaction
> org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait.testRecoveredEditsReplayCompaction
> org.apache.hadoop.hbase.util.TestFSUtils.testRenameAndSetModifyTime
> {code}
> The root causes are:
> - Using local file name for referring to hdfs paths (HBASE-6830)
> - Classloader using the wrong file system
> - StoreFile readers not being closed (for unfinished compaction)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
