[
https://issues.apache.org/jira/browse/HBASE-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819685#comment-13819685
]
Demai Ni commented on HBASE-4654:
---------------------------------
I didn't find any javadoc warning related with this patch (a few warnings for
Bytes.java, CellUtil.java, which have been there before)
about the UT failure: org.apache.hadoop.hbase.master.TestRestartCluster, the
stacktrace also doesn't indicate any relationship with this patch, probably
caused by unstable environment
java.io.IOException: Shutting down
.....
at
org.apache.hadoop.hbase.master.TestRestartCluster.testRestartClusterAfterKill(TestRestartCluster.java:78)
I will submit to HadoopQA one more time.
> [replication] Add a check to make sure we don't replicate to ourselves
> ----------------------------------------------------------------------
>
> Key: HBASE-4654
> URL: https://issues.apache.org/jira/browse/HBASE-4654
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Demai Ni
> Fix For: 0.92.3, 0.98.0
>
> Attachments: 4654-trunk.txt, HBASE-4654-trunk-v0.patch
>
>
> It's currently possible to add a peer for replication and point it to the
> local cluster, which I believe could very well happen for those like us that
> use only one ZK ensemble per DC so that only the root znode changes when you
> want to set up replication intra-DC.
> I don't think comparing just the cluster ID would be enough because you would
> normally use a different one for another cluster and nothing will block you
> from pointing elsewhere.
> Comparing the ZK ensemble address doesn't work either when you have multiple
> DNS entries that point at the same place.
> I think this could be resolved by looking up the master address in the
> relevant znode as it should be exactly the same thing in the case where you
> have the same cluster.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
