[ 
https://issues.apache.org/jira/browse/HBASE-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820283#comment-13820283
 ] 

Ted Yu commented on HBASE-9958:
-------------------------------

{code}
+   * @param bytes
+   * @return A deserialized {@link HRegionInfo} or null if we failed 
deserialize or passed bytes null
+   * @see #toByteArray()
+   */
+  public static HRegionInfo parseFromOrNull(final byte [] bytes, int offset, 
int len) {
{code}
Javadoc for last two parameters are missing.
{code}
+   * @param bytes A pb RegionInfo serialized with a pb magic prefix.
+   * @return A deserialized {@link HRegionInfo}
+   * @throws DeserializationException
+   * @see #toByteArray()
+   */
+  public static HRegionInfo parseFrom(final byte [] bytes, int offset, int len)
{code}
Javadoc.
{code}
+          }
+
+          if (useCache) {
+            location = getCachedLocation(tableName, row);
+            if (location != null) {
+              return location;
+            }
+          }
{code}
'if (useCache)' appears twice consecutively. Consider merging the above check 
into the earlier check.

> Remove some array copy, change lock scope in locateRegion
> ---------------------------------------------------------
>
>                 Key: HBASE-9958
>                 URL: https://issues.apache.org/jira/browse/HBASE-9958
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9958.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to