[
https://issues.apache.org/jira/browse/HBASE-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821505#comment-13821505
]
Jonathan Hsieh commented on HBASE-9831:
---------------------------------------
[~lhofhansl] It has -- the initial() call is in the run method().
[~takeshi.miao] Thanks for doing this. looking at it it seems to have
affected a lot more than I expected. I think the right thing to do in the end
is to separate the HBaseFsckTool tool parts( which takes the command line
args), put the initialization of config dependent stuff back into the HBaseFsck
constructor, and push the HBaseFsck construction happen into the run method.
This way we don't affect all the tests and OfflineMetaRebuild and solve the -D
problem once and for all.
In short, let's go with the simpler patch for now (the one from before I got
involved) and file a new issue to clean up the -D problem. I can take it on or
you can -- this cleanup shouldn't block this particular fix. Let me know if
you agree.
> 'hbasefsck.numthreads' property can not pass to hbck via generic option
> -----------------------------------------------------------------------
>
> Key: HBASE-9831
> URL: https://issues.apache.org/jira/browse/HBASE-9831
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.12
> Reporter: takeshi.miao
> Priority: Minor
> Labels: hbck
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments: HBASE-9831-0.94-v02.patch, HBASE-9831-0.94-v03.patch,
> HBASE-9831-trunk-v01.patch, HBASE-9831-trunk-v02.patch,
> HBASE-9831-trunk-v03.patch, HBASE-9831.v01.patch
>
>
> We use generic option way to pass _'hbasefsck.numthreads'_ property to
> _'hbase hbck'_, but it does not accept our new setting value
> {code}
> hbase hbck -D hbasefsck.numthreads=5
> {code}
> We can still find there are threads over than 5 we already set via generic
> opttion
> {code}
> [2013-10-24
> 09:25:02,561][pool-2-thread-6][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,562][pool-2-thread-10][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,565][pool-2-thread-13][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,566][pool-2-thread-11][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,567][pool-2-thread-9][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,568][pool-2-thread-12][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,570][pool-2-thread-7][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,571][pool-2-thread-14][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
