[
https://issues.apache.org/jira/browse/HBASE-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821942#comment-13821942
]
stack commented on HBASE-3787:
------------------------------
What is this change?
"...changed to interface to separate client id impl from the interface; "
I skimmed the patch (RB is down). EIther you fixed it or I was confused. I
see a clientidnonce thingy now and it has mention of client id internal... that
is fine (if that was how it always was, discount my RB comment . If you
changed stuff, thanks).
+1 on commit. Important fix. Thanks for the persistence Sergey. Work it out
w/ [~ndimiduk] so you can commit this before you leave so it doesn't rot again.
> Increment is non-idempotent but client retries RPC
> --------------------------------------------------
>
> Key: HBASE-3787
> URL: https://issues.apache.org/jira/browse/HBASE-3787
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.94.4, 0.95.2
> Reporter: dhruba borthakur
> Assignee: Sergey Shelukhin
> Priority: Blocker
> Attachments: HBASE-3787-partial.patch, HBASE-3787-v0.patch,
> HBASE-3787-v1.patch, HBASE-3787-v10.patch, HBASE-3787-v11.patch,
> HBASE-3787-v2.patch, HBASE-3787-v3.patch, HBASE-3787-v4.patch,
> HBASE-3787-v5.patch, HBASE-3787-v5.patch, HBASE-3787-v6.patch,
> HBASE-3787-v7.patch, HBASE-3787-v8.patch, HBASE-3787-v9.patch
>
>
> The HTable.increment() operation is non-idempotent. The client retries the
> increment RPC a few times (as specified by configuration) before throwing an
> error to the application. This makes it possible that the same increment call
> be applied twice at the server.
> For increment operations, is it better to use
> HConnectionManager.getRegionServerWithoutRetries()? Another option would be
> to enhance the IPC module to make the RPC server correctly identify if the
> RPC is a retry attempt and handle accordingly.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
