[
https://issues.apache.org/jira/browse/HBASE-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823382#comment-13823382
]
Hadoop QA commented on HBASE-9970:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614012/HBASE-9970.java.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7877//console
This message is automatically generated.
> HBase BulkLoad, table is creating with the timestamp key also as a column to
> the table.
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-9970
> URL: https://issues.apache.org/jira/browse/HBASE-9970
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.11
> Reporter: Y. SREENIVASULU REDDY
> Assignee: Y. SREENIVASULU REDDY
> Fix For: 0.98.0, 0.96.1, 0.94.15
>
> Attachments: HBASE-9970.java.patch, HBASE-9970_94.patch
>
>
> If BulkLoad job is running with out creating a table.
> job itself will create the table if table is not found.
> {code}
> if (!doesTableExist(tableName)) {
> createTable(conf, tableName);
> }
> {code}
> if columns contains timestamp also then table is creating with defined
> columns and timestamp key.
> {quote}
> eg: -Dimporttsv.columns=HBASE_ROW_KEY,HBASE_TS_KEY,d:num
> {quote}
> table is creating with the following columnFamilies.
> 'HBASE_TS_KEY' and 'd'
> while iterating timestamp key also need to avoid while describing the column
> descriptors.
> {code}
> private static void createTable(HBaseAdmin admin, String tableName, String[]
> columns)
> throws IOException {
> HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(tableName));
> Set<String> cfSet = new HashSet<String>();
> for (String aColumn : columns) {
> if (TsvParser.ROWKEY_COLUMN_SPEC.equals(aColumn)) continue;
> // we are only concerned with the first one (in case this is a cf:cq)
> cfSet.add(aColumn.split(":", 2)[0]);
> }
> for (String cf : cfSet) {
> HColumnDescriptor hcd = new HColumnDescriptor(Bytes.toBytes(cf));
> htd.addFamily(hcd);
> }
> LOG.warn(format("Creating table '%s' with '%s' columns and default
> descriptors.",
> tableName, cfSet));
> admin.createTable(htd);
> }
> {code}
> {code}
> Index:
> hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
> ===================================================================
> ---
> hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
> (revision 1539967)
> +++
> hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
> (working copy)
> @@ -413,7 +413,8 @@
> HTableDescriptor htd = new
> HTableDescriptor(TableName.valueOf(tableName));
> Set<String> cfSet = new HashSet<String>();
> for (String aColumn : columns) {
> - if (TsvParser.ROWKEY_COLUMN_SPEC.equals(aColumn)) continue;
> + if (TsvParser.ROWKEY_COLUMN_SPEC.equals(aColumn)
> + || TsvParser.TIMESTAMPKEY_COLUMN_SPEC.equals(aColumn)) continue;
> // we are only concerned with the first one (in case this is a cf:cq)
> cfSet.add(aColumn.split(":", 2)[0]);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
