[ 
https://issues.apache.org/jira/browse/HBASE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825585#comment-13825585
 ] 

Hadoop QA commented on HBASE-9990:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12614442/9990.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 hadoop1.0{color}.  The patch failed to compile against the 
hadoop 1.0 profile.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/7920//console

This message is automatically generated.

> HTable uses the conf for each "newCaller"
> -----------------------------------------
>
>                 Key: HBASE-9990
>                 URL: https://issues.apache.org/jira/browse/HBASE-9990
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9990.v1.patch
>
>
> You can construct a RpcRetryingCallerFactory, but actually the conf is read 
> for each caller creation. Reading the conf is obviously expensive, and a 
> profiling session shows it. If we want to sent hundreds of thousands of 
> queries per second, we should not do that.
> RpcRetryingCallerFactory.newCaller is called for each get, for example.
> This is not a regression, we have something similar in 0.94.
> On the 0.96, we see the creation of: java.util.regex.Matcher: 15739712b after 
> a few thousand calls to "get".



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to