[ 
https://issues.apache.org/jira/browse/HBASE-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826117#comment-13826117
 ] 

Anoop Sam John commented on HBASE-9994:
---------------------------------------

LGTM
So you handle the above 2 classes in this patch. I can see some more places 
where we use copyFrom(). So we can do that in follow up jiras?
+1 for this change.

> ZeroCopyLiteralByteString.wrap() should be used in place of 
> ByteString.copyFrom()
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-9994
>                 URL: https://issues.apache.org/jira/browse/HBASE-9994
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 9994-v1.txt
>
>
> The following classes use ByteString.copyFrom() which should be replaced with 
> ZeroCopyLiteralByteString.wrap() :
> hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/codec/MessageCodec.java



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to