[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826162#comment-13826162
]
Jonathan Hsieh commented on HBASE-9949:
---------------------------------------
Hey [[email protected]] commented on Friday or Thursday that I'm concerned
about this infrastructure creeping in throughout the code. Specifically the in
the main comment i mentioned that "This was not addressed" and then you
committed without addressing the concern I had with the code in the review and
there were no +1's in review board. (Though sergey had a conditional +1 in
jira).
I'm assuming this was a an oversight.
To be clear, I'm basically fine with the fix -- I'm mostly concerned about the
new framework.
It seems like yet another infrastructure and it is one that I'm not
particularly fond of because of it seems cumbersome and has the potential to
perf impact in other areas if extended. This will take more work but it can be
done in a way that makes the code more readable and maintainable and I'd rather
we move in that direction instead of adding yet more one of infrastructures.
Can we instead make use a factories patterns + mocks to do this injection?
Happy to move this discussion to the mailing list.
> Fix the race condition between Compaction and StoreScanner.init
> ---------------------------------------------------------------
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
> Affects Versions: 0.89-fb
> Reporter: Manukranth Kolloju
> Assignee: Manukranth Kolloju
> Priority: Minor
> Fix For: 0.89-fb, 0.98.0
>
> Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt,
> 9949-trunk-v2.txt, 9949-trunk-v3.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
