[ 
https://issues.apache.org/jira/browse/HBASE-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832947#comment-13832947
 ] 

Tsz Wo (Nicholas), SZE commented on HBASE-10029:
------------------------------------------------

I cannot follow well on this problem:

> ,,, ConfiguredFailoverProxyProvider should implement Closeable.

ConfiguredFailoverProxyProvider<T> implements FailoverProxyProvider<T> where 
FailoverProxyProvider<T> extends Closeable.  So doesn't 
ConfiguredFailoverProxyProvider actually implement Closeable?

For the "RPC.stopProxy called on non proxy" error, could you apply the 
following in order to see what is the proxy class?
{code}
Index: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
===================================================================
--- 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
    (revision 1545796)
+++ 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
    (working copy)
@@ -634,7 +634,7 @@
     } catch (IOException e) {
       LOG.error("Closing proxy or invocation handler caused exception", e);
     } catch (IllegalArgumentException e) {
-      LOG.error("RPC.stopProxy called on non proxy.", e);
+      LOG.error("RPC.stopProxy called on non proxy: class=" + 
proxy.getClass(), e);
     }
     
     // If you see this error on a mock object in a unit test you're
{code}

> Proxy created by HFileSystem#createReorderingProxy() should properly close 
> when connecting to HA namenode
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10029
>                 URL: https://issues.apache.org/jira/browse/HBASE-10029
>             Project: HBase
>          Issue Type: Bug
>          Components: hadoop2
>    Affects Versions: 0.96.0
>            Reporter: Henry Hung
>            Assignee: Ted Yu
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 10029-hbase-hadoop-master-fphd9.out, 10029-v1.txt, 
> 10029-v2.txt, 10029-v3.txt, 10029.addendum
>
>
> HA namenode with QJM created from 
> org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider 
> should implement Closeable.
> [Mail 
> Archive|https://drive.google.com/file/d/0B22pkxoqCdvWSGFIaEpfR3lnT2M/edit?usp=sharing]
> {code}
> 13/11/26 09:55:55 ERROR ipc.RPC: RPC.stopProxy called on non proxy.
> java.lang.IllegalArgumentException: object is not an instance of declaring 
> class
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at 
> org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:266)
>         at $Proxy16.close(Unknown Source)
>         at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:621)
>         at 
> org.apache.hadoop.hdfs.DFSClient.closeConnectionToNamenode(DFSClient.java:738)
>         at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:794)
>         at 
> org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:847)
>         at 
> org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2524)
>         at 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2541)
>         at 
> org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
> 13/11/26 09:55:55 WARN util.ShutdownHookManager: ShutdownHook 
> 'ClientFinalizer' failed, org.apache.hadoop.HadoopIllegalArgumentException: 
> Cannot close proxy - is not Closeable or does not provide closeable 
> invocation handler class $Proxy16
> org.apache.hadoop.HadoopIllegalArgumentException: Cannot close proxy - is not 
> Closeable or does not provide closeable invocation handler class $Proxy16
>         at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:639)
>         at 
> org.apache.hadoop.hdfs.DFSClient.closeConnectionToNamenode(DFSClient.java:738)
>         at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:794)
>         at 
> org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:847)
>         at 
> org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2524)
>         at 
> org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2541)
>         at 
> org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to