[
https://issues.apache.org/jira/browse/HBASE-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054853#comment-13054853
]
Ted Yu commented on HBASE-4028:
-------------------------------
@Jinchao: please generate the patch at the root of source tree.
Trying to apply your patch directly would give us:
{code}
[hadoop@xxx 90hbase]$ patch -p0 -i 4028.txt
(Stripping trailing CRs from patch.)
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
|===================================================================
|--- java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
(revision 1139163)
|+++ java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
(working copy)
--------------------------
File to patch:
{code}
The correct header of patch should be:
{code}
Index: src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
===================================================================
--- src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
(revision 1139163)
+++ src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
(working copy)
{code}
> Hmaster crashes caused by splitting log.
> ----------------------------------------
>
> Key: HBASE-4028
> URL: https://issues.apache.org/jira/browse/HBASE-4028
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.3
> Reporter: gaojinchao
> Assignee: gaojinchao
> Fix For: 0.90.4
>
> Attachments: HBASE-4028-0.90V2, Screenshot-2.png, Verifiedresult.png,
> hbase-root-master-157-5-100-8.rar
>
>
> In my performance cluster(0.90.3), The Hmaster memory from 100 M up to 4G
> when one region server crashed.
> I added some print in function doneWriting and found the values of
> totalBuffered is negative.
> 10:29:52,119 WARN org.apache.hadoop.hbase.regionserver.wal.HLogSplitter:
> gjc:release Used -565832
> hbase-root-master-157-5-111-21.log:2011-06-24 10:29:52,119 WARN
> org.apache.hadoop.hbase.regionserver.wal.HLogSplitter: gjc:release Used
> -565832release size25168
> void doneWriting(RegionEntryBuffer buffer) {
> synchronized (this) {
> LOG.warn("gjc1: relase currentlyWriting +biggestBufferKey " +
> buffer.encodedRegionName );
> boolean removed = currentlyWriting.remove(buffer.encodedRegionName);
> assert removed;
> }
> long size = buffer.heapSize();
> synchronized (dataAvailable) {
> totalBuffered -= size;
> LOG.warn("gjc:release Used " + totalBuffered );
> // We may unblock writers
> dataAvailable.notifyAll();
> }
> LOG.warn("gjc:release Used " + totalBuffered + "release size"+ size);
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
