[ 
https://issues.apache.org/jira/browse/HBASE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054957#comment-13054957
 ] 

Ted Yu commented on HBASE-4002:
-------------------------------

In IntLinkedList3.copyOf():
{code}
+    int size = source.length();
+    for (int x = 0; x < size; x++) {
+      newone.set(x, source.get(x));
+    }
{code}
Should we check size against newSize and use the smaller one ?

I guess the method names below can be made more intuitive ?
{code}
+  public static void setNex(int pos, int next, AtomicIntegerArray linkedList) {
+    linkedList.set( (pos * CONST) + 1, next);
+  }
+
+  public static void setDow(int pos, int down, AtomicIntegerArray linkedList) {
+    linkedList.set( (pos * CONST) + 2, down);
+  }
{code}

> Int array based skip list
> -------------------------
>
>                 Key: HBASE-4002
>                 URL: https://issues.apache.org/jira/browse/HBASE-4002
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jason Rutherglen
>            Priority: Minor
>         Attachments: HBASE-4002.patch, HBASE-4002.patch, HBASE-4002.patch
>
>
> We can implement an AtomicIntegerArray based skip list, where the int values 
> point to locations in a byte block structure.  This can be useful for testing 
> against ConcurrentSkipListMap.  It can also be used in Lucene for the 
> realtime terms dictionary.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to