[ 
https://issues.apache.org/jira/browse/HBASE-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836928#comment-13836928
 ] 

Nick Dimiduk commented on HBASE-10061:
--------------------------------------

Why is ignoring the missing jar a good idea? The current implementation will 
fail at job preparation time when a jar is missing. This patch will cause the 
failure to happen after the job is submitted, when a class from the missing jar 
are used. Is better to fail earlier, no?

> TableMapReduceUtil.findOrCreateJar calls updateMap(null, ) resulting in 
> thrown NPE
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-10061
>                 URL: https://issues.apache.org/jira/browse/HBASE-10061
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.94.12
>            Reporter: Amit Sela
>         Attachments: 10061-trunk.txt, HBASE-10061.patch
>
>
> TableMapReduceUtil.findOrCreateJar line 596:
> jar = getJar(my_class);
> updateMap(jar, packagedClasses);
> In case getJar returns null, updateMap will throw NPE.
> Should check null==jar before calling updateMap.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to