[ 
https://issues.apache.org/jira/browse/HBASE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840584#comment-13840584
 ] 

Lars Hofhansl commented on HBASE-10089:
---------------------------------------

String interning is rarely a good idea. Looking at the code I am not even sure 
why we're doing that.
Are we creating many metrics for the same table/cf? Comparing them a lot? I do 
not find clear evidence for either. We compare the strings only on non-hot code 
paths, and it does not look like we're collect a large load of metrics per 
table/cf.

Could just get rid of the intern'ing.

> Metrics intern table names cause eventual permgen OOM in 0.94
> -------------------------------------------------------------
>
>                 Key: HBASE-10089
>                 URL: https://issues.apache.org/jira/browse/HBASE-10089
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0, 0.94.14
>            Reporter: Dave Latham
>            Priority: Minor
>
> As part of the metrics system introduced in HBASE-4768 there are two places 
> that hbase uses String interning ( SchemaConfigured and SchemaMetrics ).  
> This includes interning table names.  We have long running environment where 
> we run regular integration tests on our application using hbase.  Those tests 
> create and drop tables with new names regularly.  These leads to filling up 
> the permgen with interned table names.  Workaround is to periodically restart 
> the region servers.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to