[
https://issues.apache.org/jira/browse/HBASE-10000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840793#comment-13840793
]
Jeffrey Zhong commented on HBASE-10000:
---------------------------------------
[[email protected]] I didn't see where you fetch the TS stored in ZK PBed data
when we do slt = SplitLogTask.parseFrom(data); in SplitLogWorker.java.
For upgrade the scenario, we need to make sure to handle when there is no TS
stored from old SLT task data. So the following code, this.ts is better to use
the constant LEASE_RECOVERY_UNREQUESTED.(though currently they have same
value). If not too hard, it's better add a test case to cover this new
behavior. Rest looks good to me. Thanks.
{code}
SplitLogTask(final ServerName originServer, final
ZooKeeperProtos.SplitLogTask.State state) {
this.originServer = originServer;
this.state = state;
+ this.ts = 0;
}
{code}
> Initiate lease recovery for outstanding WAL files at the very beginning of
> recovery
> -----------------------------------------------------------------------------------
>
> Key: HBASE-10000
> URL: https://issues.apache.org/jira/browse/HBASE-10000
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.1
>
> Attachments: 10000-recover-ts-with-pb-2.txt,
> 10000-recover-ts-with-pb-2.txt, 10000-v1.txt, 10000-v4.txt, 10000-v5.txt,
> 10000-v6.txt
>
>
> At the beginning of recovery, master can send lease recovery requests
> concurrently for outstanding WAL files using a thread pool.
> Each split worker would first check whether the WAL file it processes is
> closed.
> Thanks to Nicolas Liochon and Jeffery discussion with whom gave rise to this
> idea.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
