[
https://issues.apache.org/jira/browse/HBASE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841128#comment-13841128
]
Liang Xie commented on HBASE-10010:
-----------------------------------
seems no reponse from ted.
[[email protected]], [[email protected]], what do you think of
trunk-v2.txt patch ? IIRC, trunk now use hadoop2 by default, right?
Here is the code snippet from hadoop branch2:
{code}
/** Write and flush the file header. */
private void writeFileHeader()
throws IOException {
out.write(VERSION);
Text.writeString(out, keyClass.getName());
Text.writeString(out, valClass.getName());
out.writeBoolean(this.isCompressed());
out.writeBoolean(this.isBlockCompressed());
if (this.isCompressed()) {
Text.writeString(out, (codec.getClass()).getName());
}
this.metadata.write(out);
out.write(sync); // write the sync bytes
out.flush(); // flush header
}
{code}
To me, i would like the trunk-v2's style againt v1's dummy record method:)
more cleaner and lower risk.
> eliminate the put latency spike on the new log file beginning
> -------------------------------------------------------------
>
> Key: HBASE-10010
> URL: https://issues.apache.org/jira/browse/HBASE-10010
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.94.13
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HBase-10010-0.94-v2.txt, HBase-10010-0.94-v3.txt,
> HBase-10010-0.94.txt, HBase-10010-trunk-v2.txt, HBase-10010-trunk.txt
>
>
> In deed, the original finding came from fb, see HBASE-6813 for detailed
> discussion.
> Through this improvement doesn't expect obvious gain on 95th or 99th latency,
> it still could make the response time more stable to me.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
