[ 
https://issues.apache.org/jira/browse/HBASE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842188#comment-13842188
 ] 

Hudson commented on HBASE-10093:
--------------------------------

SUCCESS: Integrated in HBase-0.94 #1220 (See 
[https://builds.apache.org/job/HBase-0.94/1220/])
HBASE-10093 Unregister ReplicationSource metric bean when the replication 
source thread is terminated (cuijianwei) (larsh: rev 1548802)
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java


> Unregister ReplicationSource metric bean when the replication source thread 
> is terminated 
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10093
>                 URL: https://issues.apache.org/jira/browse/HBASE-10093
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 0.94.14
>            Reporter: cuijianwei
>            Assignee: cuijianwei
>             Fix For: 0.94.15
>
>         Attachments: HBASE-10093-0.94-v1.patch
>
>
> Each replication source thread will register a metric bean to show its 
> statistics. The source threads will be terminated when region server exit and 
> the metric beans will be removed. However, replication source thread may also 
> be terminated when user removing the peer explicitly or it just takes a 
> recover queue and finished replicating the queued HLogs. In these situations, 
> the metric bean won't be unregistered and user may be confused to always see 
> the statistics from terminated replication source threads. Maybe, it is more 
> clear to remove the metric bean after replication source thread terminated? 
> Then, the statistics will only from active replication sources.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to