[
https://issues.apache.org/jira/browse/HBASE-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842826#comment-13842826
]
stack commented on HBASE-10101:
-------------------------------
Hey Jibin, on v3, I don't get this bit:
{code}
ZKAssign.createOrForceNodeOffline(this.watcher, regionInfo, sn);
regionStates.updateRegionState(regionInfo, State.OFFLINE, sn);
+ // We need to reset last assignment info for the region because
+ // 1) we force current RIT state to be offline which means the region
isn't assigned anywhere.
+ // 2) Otherwise they may be skipped by
regionStates.wasRegionOnDeadServer in SSH region
+ // assignment
+ regionStates.setLastRegionServerOfRegion(sn, regionInfo);
{code}
We are setting the servername but didn't we just do it up in
createOrForceNodeOffline?
We are doing the above because region could have come from another RS
altogether, one that did not get fully processed? Now we force it to be on
the current dead server?
> testOfflineRegionReAssginedAfterMasterRestart times out sometimes.
> ------------------------------------------------------------------
>
> Key: HBASE-10101
> URL: https://issues.apache.org/jira/browse/HBASE-10101
> Project: HBase
> Issue Type: Test
> Reporter: Jimmy Xiang
> Assignee: Jeffrey Zhong
> Priority: Minor
> Attachments: hbase-10101-v2.patch, hbase-10101-v3.patch,
> hbase-10101.patch, test.log
>
>
> Sometimes, I got this test timed out. The log is attached. It could be
> because the new cluster takes a while to process the dead server, or assign
> meta.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
