[ 
https://issues.apache.org/jira/browse/HBASE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844555#comment-13844555
 ] 

stack commented on HBASE-10119:
-------------------------------

bq. For 0.96, this seems like a reasonable change, and Benoit needs it, but it 
does change the semantics around failed coprocessors.

When we do shutdown(env), whose env are we shutting down -- just the failed 
cps?  Or the total cp env?  If the former, +1 on 0.96.  It seems this patch is 
more a fix than a change in semantics?

> Allow HBase coprocessors to clean up when they fail
> ---------------------------------------------------
>
>                 Key: HBASE-10119
>                 URL: https://issues.apache.org/jira/browse/HBASE-10119
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.96.0
>            Reporter: Benoit Sigoure
>         Attachments: HBASE-10119.patch
>
>
> In the thread [Giving a chance to buggy coprocessors to clean 
> up|http://osdir.com/ml/general/2013-12/msg17334.html] I brought up the issue 
> that coprocessors currently don't have a chance to release their own 
> resources (be they internal resources within the JVM, or external resources 
> elsewhere) when they get forcefully removed due to an uncaught exception 
> escaping.
> It would be nice to fix that, either by adding an API called by the 
> {{CoprocessorHost}} when killing a faulty coprocessor, or by guaranteeing 
> that the coprocessor's {{stop()}} method will be invoked then.
> This feature request is actually pretty important due to bug HBASE-9046, 
> which means that it's not possible to properly clean up a coprocessor without 
> restarting the RegionServer (!!).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to