[ 
https://issues.apache.org/jira/browse/HBASE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845487#comment-13845487
 ] 

Nick Dimiduk commented on HBASE-10129:
--------------------------------------

Nice feature. Any chance of a patch for trunk?

Skimmed the patch:

{noformat}
   public void doUpdates(final MetricsContext context) {
+    for (Entry<String, MetricsTimeVaryingHistogram> entry : 
methodHistograms.entrySet()) {
+      
MetricsTimeVaryingHistogram.registerTimeVaryingHistogramMetric(entry.getKey(),
+        entry.getValue(), this.registry);
+      entry.getValue().pushMetric(metricsRecord);
+    }
{noformat}

Can registration be handled once on initialization rather than with every call 
do doUpdates?

> support real time rpc invoke latency percentile statistics for methods of 
> HRegionInterface 
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10129
>                 URL: https://issues.apache.org/jira/browse/HBASE-10129
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.14
>            Reporter: cuijianwei
>         Attachments: HBASE-10129-0.94-v1.patch
>
>
> It is important for applications to get latency statistics when invoking 
> hbase apis. Currently, the average latency of methods in HRegionInterface 
> will be computed in HBaseRpcMetrics. However, user might expect more detail 
> latency statistics, such as 75% percentile latency, 95% percentile latency, 
> etc. Therefore, will it be useful if we computing latency percentiles for rpc 
> invoking of region server methods? 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to