[
https://issues.apache.org/jira/browse/HBASE-10000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846008#comment-13846008
]
stack commented on HBASE-10000:
-------------------------------
A single test run does not prove resilience. I am working on other stuff so do
not have time to hold your hand and do you up a test plan. If you can't figure
out how to prove this patch to a super critical section works in a variety of
fails, -1 on this patch going in (The last time you did a patch in this area, I
personally had to spend multiple days fixing a distribution I work on to
address a dataloss issue that had been introduced setting lease recovery timers
too low for real loadings -- so I am a little sensitive when changes in this
area).
> Initiate lease recovery for outstanding WAL files at the very beginning of
> recovery
> -----------------------------------------------------------------------------------
>
> Key: HBASE-10000
> URL: https://issues.apache.org/jira/browse/HBASE-10000
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.1
>
> Attachments: 10000-0.96-v5.txt, 10000-0.96-v6.txt,
> 10000-recover-ts-with-pb-2.txt, 10000-recover-ts-with-pb-3.txt,
> 10000-recover-ts-with-pb-4.txt, 10000-recover-ts-with-pb-5.txt,
> 10000-recover-ts-with-pb-6.txt, 10000-recover-ts-with-pb-7.txt,
> 10000-recover-ts-with-pb-8.txt, 10000-recover-ts-with-pb-8.txt, 10000-v4.txt,
> 10000-v5.txt, 10000-v6.txt
>
>
> At the beginning of recovery, master can send lease recovery requests
> concurrently for outstanding WAL files using a thread pool.
> Each split worker would first check whether the WAL file it processes is
> closed.
> Thanks to Nicolas Liochon and Jeffery discussion with whom gave rise to this
> idea.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
