[ 
https://issues.apache.org/jira/browse/HBASE-10076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847017#comment-13847017
 ] 

Jesse Yates commented on HBASE-10076:
-------------------------------------

bq. Any interest in bringing in the new test TestCellUtil. 
testOverlappingKeys() ? Not needed that much, just checking

Done - good call.

bq. Not sure about the change in TableInputFormatBase. Is this needed? Let's 
leave this out otherwise.

Not needed, but this is a cleaner, better implementation and good to reuse the 
util, now that we have it. Agree its a little extra and a bit unneccessary, but 
trivially so.

bq. In the original patch, TableMapReduceUtil. initTableMapperJob() now accepts 
an initCredentials param, because we do not want to get tokens from HBase at 
all. Otherwise, if hbase is used with security, offline clusters won't work.

Looks like in 0.94 its just added based on the config. In trunk, looks like 
TableMapReduceUtil.initTableSnapshotMapperJob just calls initTableMapperJob 
without any parameter, which always initializes the credentials. Maybe a bug in 
trunk? Seems like you would need a more sweeping change to make it configurable 
as well.

> Backport MapReduce over snapshot files [0.94]
> ---------------------------------------------
>
>                 Key: HBASE-10076
>                 URL: https://issues.apache.org/jira/browse/HBASE-10076
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Jesse Yates
>             Fix For: 0.94.15
>
>         Attachments: hbase-10076-v0.patch
>
>
> MapReduce over Snapshots would be valuable on 0.94.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to