[
https://issues.apache.org/jira/browse/HBASE-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849669#comment-13849669
]
Hadoop QA commented on HBASE-8533:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12584868/8533-0.95-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8177//console
This message is automatically generated.
> HBaseAdmin does not ride over cluster restart
> ---------------------------------------------
>
> Key: HBASE-8533
> URL: https://issues.apache.org/jira/browse/HBASE-8533
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Affects Versions: 0.98.0, 0.95.0
> Reporter: Julian Zhou
> Assignee: Julian Zhou
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 8533-0.95-v1.patch, 8533-trunk-v1.patch,
> hbase-8533-trunk-v0.patch
>
>
> For Restful servlet (org.apache.hadoop.hbase.rest.Main (0.94),
> org.apache.hadoop.hbase.rest.RESTServer (trunk)) on Jetty, we need to first
> explicitly start the service (% ./bin/hbase-daemon.sh start rest -p 8000 )
> for application running. Here is a scenario, sometimes, HBase cluster are
> stopped/started for maintanence, but rest is a seperated standalone process,
> which binds the HBaseAdmin at construction method.
> HBase stop/start cause this binding lost for existing rest servlet. Rest
> servlet still exist to trying on old bound HBaseAdmin until a long time
> duration later with an "Unavailable" caught via an IOException caught in
> such as RootResource.
> Could we pairwise the HBase service with HBase rest service with some
> start/stop options? since seems no reason to still keep the rest servlet
> process after HBase stopped? When HBase restarts, original rest service could
> not resume to bind to the new HBase service via its old HBaseAdmin reference?
> So may we stop the rest when hbase stopped, or even if hbase was killed by
> acident, restart hbase with rest option could detect the old rest process,
> kill it and start to bind a new one?
> From this point of view, application rely on rest api in previous scenario
> could immediately detect it when setting up http connection session instead
> of wasting a long time to fail back from IOException with "Unavailable" from
> rest servlet.
> Put current options from the discussion history here from Andrew, Stack and
> Jean-Daniel,
> 1) create an HBaseAdmin on demand in rest servlet instead of keeping
> singleton instance; (another possible enhancement for HBase client: automatic
> reconnection of an open HBaseAdmin handle after a cluster bounce?)
> 2) pairwise the rest webapp with hbase webui so the rest is always on with
> HBase serive;
> 3) add an option for rest service (such as HBASE_MANAGES_REST) in
> hbase-env.sh, set HBASE_MANAGES_REST to true, the scripts will start/stop the
> REST server.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
