[ 
https://issues.apache.org/jira/browse/HBASE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849684#comment-13849684
 ] 

Hadoop QA commented on HBASE-7579:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12576365/HBASE-7579-v5.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8182//console

This message is automatically generated.

> HTableDescriptor equals method fails if results are returned in a different 
> order
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-7579
>                 URL: https://issues.apache.org/jira/browse/HBASE-7579
>             Project: HBase
>          Issue Type: Bug
>          Components: Admin
>    Affects Versions: 0.94.6, 0.95.0
>            Reporter: Aleksandr Shulman
>            Assignee: Aleksandr Shulman
>            Priority: Minor
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-7579-0.94.patch, HBASE-7579-v1.patch, 
> HBASE-7579-v2.patch, HBASE-7579-v3.patch, HBASE-7579-v4.patch, 
> HBASE-7579-v5.patch
>
>
> HTableDescriptor's compareTo function compares a set of HColumnDescriptors 
> against another set of HColumnDescriptors. It iterates through both, relying 
> on the fact that they will be in the same order.
> In my testing, I may have seen this issue come up, so I decided to fix it.
> It's a straightforward fix. I convert the sets into a hashset for O(1) 
> lookups (at least in theory), then I check that all items in the first set 
> are found in the second.
> Since the sizes are the same, we know that if all elements showed up in the 
> second set, then they must be equal.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to