[
https://issues.apache.org/jira/browse/HBASE-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849868#comment-13849868
]
Hadoop QA commented on HBASE-10179:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618994/10179-against-0.94-branch.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8192//console
This message is automatically generated.
> HRegionServer underreports readRequestCounts by 1 under certain conditions
> --------------------------------------------------------------------------
>
> Key: HBASE-10179
> URL: https://issues.apache.org/jira/browse/HBASE-10179
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.94.6, 0.99.0
> Reporter: Perry Trolard
> Priority: Minor
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10179-against-0.94-branch.diff, 10179-against-trunk.diff
>
>
> In HRegionServer.scan(), if
> (a) the number of results returned, n, is greater than zero
> (b) but less than the size of the batch (nbRows)
> (c) and the size in bytes is smaller than the max size (maxScannerResultSize)
> then the readRequestCount will be reported as n - 1 rather than n. (This is
> because the for-loop counter i is used to update the readRequestCount, and if
> the scan runs out of rows before reaching max rows or size, the code `break`s
> out of the loop and i is not incremented for the final time.)
> To reproduce, create a test table and open its details page in the web UI.
> Insert a single row, then note the current request count, c. Scan the table,
> returning 1 row; the request count will still be c, whereas it should be c +
> 1.
> I have a patch against TRUNK I can submit. At Splice Machine we're running
> 0.94, & I'd be happy to submit a patch against that as well.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
