[
https://issues.apache.org/jira/browse/HBASE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852237#comment-13852237
]
Hadoop QA commented on HBASE-8112:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12619397/HBASE-8112-v3-trunk.patch
against trunk revision .
ATTACHMENT ID: 12619397
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8217//console
This message is automatically generated.
> Deprecate HTable#batch(final List<? extends Row>)
> -------------------------------------------------
>
> Key: HBASE-8112
> URL: https://issues.apache.org/jira/browse/HBASE-8112
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
> Attachments: HBASE-8112-v0-trunk.patch, HBASE-8112-v1-trunk.patch,
> HBASE-8112-v2-trunk.patch, HBASE-8112-v3-trunk.patch
>
>
> This was brought up by Amit's inquiry on mailing list, entitled 'Batch
> returned value and exception handling'
> Here is his sample code:
> {code}
> Object[] res = null;
> try {
> res = table.batch(batch);
> } catch (RetriesExhaustedWithDetailsException
> retriesExhaustedWithDetailsException) {
> retriesExhaustedWithDetailsException.printStackTrace();
> }
> if (res == null) {
> System.out.println("No results - returned null.");
> }
> {code}
> When RetriesExhaustedWithDetailsException was thrown from batch() call,
> variable res carried value of null.
> Meaning user wouldn't get partial result along with the exception.
> We should deprecate {code}HTable#batch(final List<? extends Row>){code} and
> refer to the following method:
> void batch(final List<?extends Row> actions, final Object[] results) throws
> IOException, InterruptedException;
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
