[
https://issues.apache.org/jira/browse/HBASE-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853652#comment-13853652
]
Anoop Sam John commented on HBASE-9346:
---------------------------------------
Thanks JM for the updated patch.
One more small change needed.. Sorry I missed this in last comments set.
{code}
+ if ((currentRegionBoundariesInformation.storesLastKey != null)
+ && (currentRegionBoundariesInformation.metaLastKey != null)) {
+ valid = valid
+ &&
comparator.compare(currentRegionBoundariesInformation.storesLastKey,
+ currentRegionBoundariesInformation.metaLastKey) <= 0;
+ }
The storesLastKey can never be equal to metaLastKey right? It should be <
metaLastKey... This can be changed on commit ? Ted are you going with the
commit ?
Other than this +1.
{code}
> HBCK should provide an option to check if regions boundaries are the same in
> META and in stores.
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-9346
> URL: https://issues.apache.org/jira/browse/HBASE-9346
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Affects Versions: 0.94.14, 0.98.1, 0.99.0, 0.96.1.1
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Attachments: HBASE-9346-v0-0.94.patch, HBASE-9346-v1-trunk.patch,
> HBASE-9346-v2-trunk.patch, HBASE-9346-v3-trunk.patch,
> HBASE-9346-v4-trunk.patch, HBASE-9346-v5-trunk.patch,
> HBASE-9346-v6-trunk.patch, HBASE-9346-v7-trunk.patch,
> HBASE-9346-v8-trunk.patch
>
>
> If META don't have the same region boundaries as the stores files, writes and
> read might go to the wrong place. We need to provide a way to check that
> withing HBCK.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
