[ 
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853978#comment-13853978
 ] 

Hudson commented on HBASE-10138:
--------------------------------

FAILURE: Integrated in HBase-0.98 #26 (See 
[https://builds.apache.org/job/HBase-0.98/26/])
HBASE-10138. Incorrect or confusing test value is used in block caches (Sergey 
Shelukhin) (apurtell: rev 1552505)
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java


> incorrect or confusing test value is used in block caches
> ---------------------------------------------------------
>
>                 Key: HBASE-10138
>                 URL: https://issues.apache.org/jira/browse/HBASE-10138
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10138.patch
>
>
> DEFAULT_BLOCKSIZE_SMALL is described as:
> {code}
>   // Make default block size for StoreFiles 8k while testing.  TODO: FIX!
>   // Need to make it 8k for testing.
>   public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
> {code}
> This value is used on production path in CacheConfig thru HStore/HRegion, and 
> passed to various cache object.
> We should change it to actual block size, or if it is somehow by design at 
> least we should clarify it and remove the comment. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to